Add V1_1 to NTVTR
#830
Open
Add V1_1 to NTVTR
#830
+143
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDall
reviewed
Nov 10, 2025
Comment on lines
+62
to
+97
| class V1_1(V1): | ||
| VALID_UNTIL = datetime.date.today() | ||
|
|
||
| _paragraph_selector = XPath("//div[contains(@class, 'content')]/p[text()]") | ||
| _summary_selector = XPath("//h2") | ||
| _subheadline_selector = XPath("//div[contains(@class, 'content')]/p[not(text()) and strong]") | ||
|
|
||
| _topics_selector = XPath("(//ul[contains(@class, 'text-[#3D619B]')])[1]/li") | ||
|
|
||
| @attribute | ||
| def body(self) -> Optional[ArticleBody]: | ||
| return extract_article_body_with_selector( | ||
| self.precomputed.doc, | ||
| paragraph_selector=self._paragraph_selector, | ||
| summary_selector=self._summary_selector, | ||
| subheadline_selector=self._subheadline_selector, | ||
| ) | ||
|
|
||
| @attribute | ||
| def topics(self) -> List[str]: | ||
| return generic_topic_parsing( | ||
| strip_nodes_to_text(self._topics_selector(self.precomputed.doc), join_on=","), | ||
| substitution_pattern=re.compile(r"-\s*$"), | ||
| delimiter=",", | ||
| ) | ||
|
|
||
| @attribute | ||
| def images(self) -> List[Image]: | ||
| return image_extraction( | ||
| doc=self.precomputed.doc, | ||
| paragraph_selector=self._paragraph_selector, | ||
| upper_boundary_selector=CSSSelector("h1"), | ||
| lower_boundary_selector=XPath("(//img[@alt='Google Play'])[1]"), | ||
| image_selector=XPath("//div[@property='articleBody']//img[not(@fetchpriority='auto')]"), | ||
| author_selector=XPath("./ancestor::div[contains(@class,'relative') and (picture or img)]/div"), | ||
| ) |
Collaborator
There was a problem hiding this comment.
That looks like it might be worth opening a new major version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.